During ALTER COLUMN TYPE of an indexed column, we check if the index can be re-used. If so, we preserve the existing relfilenode instead of removing it. However, in GPDB the preservation is done on QD and the relfilenode is packaged in another ALTER TABLE subcommand to be handled later. So QE might make its index to have QD's relfilenode, which could cause data missing/corruption errors.
The fix is for QE to go through the generated index command, and replace QD's relfilenode with its own.
fix #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
[ ] Make sure your Pull Request has a clear title and commit message. You can take git-commit template as a reference.
[ ] Sign the Contributor License Agreement as prompted for your first-time contribution(One-time setup).
During ALTER COLUMN TYPE of an indexed column, we check if the index can be re-used. If so, we preserve the existing relfilenode instead of removing it. However, in GPDB the preservation is done on QD and the relfilenode is packaged in another ALTER TABLE subcommand to be handled later. So QE might make its index to have QD's relfilenode, which could cause data missing/corruption errors.
The fix is for QE to go through the generated index command, and replace QD's relfilenode with its own.
fix #ISSUE_Number
Change logs
Describe your change clearly, including what problem is being solved or what feature is being added.
If it has some breaking backward or forward compatibility, please clary.
Why are the changes needed?
Describe why the changes are necessary.
Does this PR introduce any user-facing change?
If yes, please clarify the previous behavior and the change this PR proposes.
How was this patch tested?
Please detail how the changes were tested, including manual tests and any relevant unit or integration tests.
Contributor's Checklist
Here are some reminders and checklists before/when submitting your pull request, please check them:
make installcheckmake -C src/test installcheck-cbdb-parallelcloudberrydb/devteam for review and approval when your PR is ready🥳