When selecting and placing a valid word 'aid', clicking play does not progress the game and results in the exception: Exception in thread "AWT-EventQueue-0" java.lang.IndexOutOfBoundsException: Index 0 out of bounds for length 0
I followed the instructions from the readme file
If it helps to debug, I ran the game with 'java -jar ScrabbleGame.jar'
I could not test game play extensively because of this
Documentation:
-Some sequence diagrams are trivial and unnecessary. Only Play and swap letters are useful. Maybe consider sequence diagrams for different 'play' sequences (valid vs invalid word vs branch word, etc).
Code Smells:
-You have business logic (such as getBranchWords, etc) in the controller. These functions should be in the model. The controller should be very light-weight and just delegate to the model.
-Strings with specific meaning in your code (such as "Skip") should be represented with a constant
-Controller's actionPerformed method is long and contains logic that can be split into sub-functions
Good job with testing, and taking M1 feedback into account.
Zhangjason308
commented
1 year ago
Same as brightspace:
General:
I followed the instructions from the readme file If it helps to debug, I ran the game with 'java -jar ScrabbleGame.jar' I could not test game play extensively because of this
Documentation:
-Some sequence diagrams are trivial and unnecessary. Only Play and swap letters are useful. Maybe consider sequence diagrams for different 'play' sequences (valid vs invalid word vs branch word, etc).
Code Smells:
-You have business logic (such as getBranchWords, etc) in the controller. These functions should be in the model. The controller should be very light-weight and just delegate to the model. -Strings with specific meaning in your code (such as "Skip") should be represented with a constant -Controller's actionPerformed method is long and contains logic that can be split into sub-functions
Good job with testing, and taking M1 feedback into account.