search

Zhangjinso / PISE

123 stars 28 forks source link

a question about the code #16

Closed happyday521 closed 3 years ago

happyday521 commented 3 years ago

I have a question about the code. In my opinion, as shown in the Fig, the code from line 627-638 should be aligned with the line 605. In other words, I think you should first finish the for loop about b_size to obtain the middle_avg before performing subsequent operations. Please check it. Thanks! image

Zhangjinso commented 3 years ago

Wow, you are right! Maybe it is produced when I am sleeping, who knows. Thanks for pointing this out. It can decrease the training speed, but it will not affect the final results. Anyway, thanks for your help.

happyday521 commented 3 years ago

:)