Closed siv2r closed 3 months ago
This pull request is ready for review. I tried to split this into multiple PRs, but the changes depended on each other, so I kept them together.
Currently, the test_pre_sign_generation()
, test_pre_sign_nonce()
, and test_pre_sign_nonce_without_auxrand()
tests (in reference.py) throw mypy errors because I introduced the PlainPk
and XonlyPk
types.
Should we move these tests into a new file or remove them altogether? These tests are incomplete, and I don’t see such tests in other BIP reference codes (except here).
Great Job! Will add more test vectors to increase the test coverage.
Fixes #9 Addresses #10
Currently, test vectors for all the APIs are present in a single CSV file. This PR splits them into two CSV files.
schnorr_presig_sign
andschnorr_extract_adaptor
APIsschnorr_adapt
andschnorr_extract_secadaptor
APIsTodo List: