ZhePang / Python_Specification_for_Schnorr_Adaptor

5 stars 4 forks source link

Modify extract adaptor algorithm #16

Closed siv2r closed 3 months ago

siv2r commented 4 months ago

Fixes #10 Fixes #14 Fixes #15

I've rebased this pull request on top of #12. Please merge #12 before merging this one.

siv2r commented 3 months ago

./tests.sh fails for me:

Yes, these fails happen in the test_pre_sign_generation (), test_pre_sign_nonce (), and test_pre_sign_nonce_without_auxrand() functions. I planned to fix this in another PR because these functions need other fixes, too (variable renaming, removal of #type ignore).

Alternatively, we can remove these functions completely:

So, removing them seems like a simple fix without significant loss.

jonasnick commented 3 months ago

Alternatively, we can remove these functions completely:

If we'd remove all three tests then we wouldn't have a randomized end-to-end test anymore. But maybe we can merge the three tests into one, since they seem to be testing similar things.