search

ZhengPeiRu21 / mod-challenge-modes

Challenge Modes Module for AzerothCore
MIT License
40 stars 40 forks source link

The script needs to be updated #21

Closed ddk2001 closed 1 year ago

ddk2001 commented 1 year ago

Now the latest source code compilation error is ChallengeMode::OnGiveXP(player, amount, victim); No detailed parameters。

void OnGiveXP(Player player, uint32& amount, Unit /victim/) override Change to void OnGiveXP(Player player, uint32& amount, Unit /victim/, uint8 /xpSource/) override

ddk2001 commented 1 year ago

void OnGiveXP(Player player, uint32& amount, Unit /victim/, uint8 / xpSource /)

RazorX2016 commented 1 year ago

this is the fix: From: void OnGiveXP(Player player, uint32& amount, Unit / victim /) override To: void OnGiveXP(Player player, uint32& amount, Unit / victim /, uint8 / xpSource /) override

*(delete spaces between / and victim and xpSource above except the space after Unit)**

From: void OnGiveXP(Player player, uint32& amount, Unit victim) override { ChallengeMode::OnGiveXP(player, amount, victim); } To: void OnGiveXP(Player player, uint32& amount, Unit victim, uint8 xpSource) override { ChallengeMode::OnGiveXP(player, amount, victim, xpSource); }

From: void OnGiveXP(Player player, uint32& amount, Unit victim) override { if (!sChallengeModes->challengeEnabledForPlayer(SETTING_QUEST_XP_ONLY, player)) { return; } if (victim) { amount = 0; } else { ChallengeMode::OnGiveXP(player, amount, victim); } } To: void OnGiveXP(Player player, uint32& amount, Unit victim, uint8 xpSource) override { if (!sChallengeModes->challengeEnabledForPlayer(SETTING_QUEST_XP_ONLY, player)) { return; } if (victim) { amount = 0; } else { ChallengeMode::OnGiveXP(player, amount, victim, xpSource); } }

Pastebin link to the fixed ChallengeModes.cpp file

ZhengPeiRu21 commented 1 year ago

Thank you for the reports. This should be fixed in https://github.com/ZhengPeiRu21/mod-challenge-modes/commit/ffbb266ede4c1850684721378d0cf40c75c2e78c.