ZhengPeiRu21 / mod-challenge-modes

Challenge Modes Module for AzerothCore
MIT License
40 stars 40 forks source link

BUG #24

Closed ElminsterCN closed 11 months ago

ElminsterCN commented 1 year ago

After the character dies, it can be resurrected by going online again. Please fix this bug, thank you!

ZhengPeiRu21 commented 1 year ago

Thank you for the report, I will investigate.

Viskus commented 12 months ago

Hi @ZhengPeiRu21 is there any update on this one? I'm only using the module for the hardcore aspect but stuck on this also :)

ZhengPeiRu21 commented 12 months ago

This should be resolved with https://github.com/ZhengPeiRu21/mod-challenge-modes/commit/8fb291d59eb796f84c51c91b2c58060549daf060. Would you please check if it continues to have issues?

Viskus commented 12 months ago

I'm getting a warning when compiling @ZhengPeiRu21 it maybe nothing but worth noting for you. /home/soap/azerothcore/modules/mod-challenge-modes/src/ChallengeModes.cpp:24:13: warning: enumeration value 'HARDCORE_DEAD' not handled in switch [-Wswitch] switch (setting) ^~~~~~~ /home/soap/azerothcore/modules/mod-challenge-modes/src/ChallengeModes.cpp:48:13: warning: enumeration value 'HARDCORE_DEAD' not handled in switch [-Wswitch] switch (setting) ^~~~~~~ /home/soap/azerothcore/modules/mod-challenge-modes/src/ChallengeModes.cpp:72:13: warning: enumeration value 'HARDCORE_DEAD' not handled in switch [-Wswitch] switch (setting) ^~~~~~~ /home/soap/azerothcore/modules/mod-challenge-modes/src/ChallengeModes.cpp:96:13: warning: enumeration value 'HARDCORE_DEAD' not handled in switch [-Wswitch] switch (setting) ^~~~~~~ /home/soap/azerothcore/modules/mod-challenge-modes/src/ChallengeModes.cpp:120:13: warning: enumeration value 'HARDCORE_DEAD' not handled in switch [-Wswitch] switch (setting)

ZhengPeiRu21 commented 12 months ago

I'm getting a warning when compiling

Thank you for testing. The warning wouldn't have impacted anything but I have cleaned it up in https://github.com/ZhengPeiRu21/mod-challenge-modes/commit/f2918a78219e7315ec65c9e07199170c4b27e225. Please let me know if you see any other issues.

Viskus commented 12 months ago

Thanks @ZhengPeiRu21 that has fixed the warning issue. --other issue sorted--