ZhengPeiRu21 / mod-challenge-modes

Challenge Modes Module for AzerothCore
MIT License
40 stars 40 forks source link

Disconnection after death #28

Open Viskus opened 11 months ago

Viskus commented 11 months ago

Hi ZhengPeiRu21, Is it an intended feature to disconnect after you click release spirit or try and revive your character? Maybe I'm missing some config?

This is on HardCore Mode (I'm not working with any other mode currently)

netweaver commented 11 months ago

I suggest that in hardcore mode, characters should be allowed to log in after death, but cannot be resurrected. It is best to maintain a soul state in order to handle guild and other matters

ZhengPeiRu21 commented 11 months ago

Yes, this is intended behavior. Currently AzerothCore does not have the necessary hooks to prevent resurrection. If these can be added to the core, then the module can be revised to allow logging in as a ghost.

Viskus commented 11 months ago

I agree that the character should not be deleted and should be able to login etc. I will put up a request in AC repo to see if anyone else would like to see the hooks added to the core, thanks again

yuanf225 commented 11 months ago

I agree that the character should not be deleted and should be able to login etc. I will put up a request in AC repo to see if anyone else would like to see the hooks added to the core, thanks again

No PR was found for this hook. Did you submit this request?

netweaver commented 11 months ago

@yuanf225 i will PR soon ( both on AC and eluna side), tested ok by creating a lua script fully implement hardcore mode.

Viskus commented 10 months ago

I've added one here for AZ core - https://github.com/azerothcore/azerothcore-wotlk/issues/17370

netweaver commented 10 months ago

pull request https://github.com/azerothcore/azerothcore-wotlk/pull/17460