search

ZhengPeiRu21 / mod-challenge-modes

Challenge Modes Module for AzerothCore
MIT License
40 stars 40 forks source link

Items worn under Iron Man or Item Quality levels are not removed due to character loading order #7

Closed drozco closed 1 year ago

drozco commented 1 year ago

Characters are loaded when logging on by AC calling CanEquipItem first for every item on the char and then _LoadCharacterSettings is called. Problem is, the challenges fail to unload any items equipped by the character since the character settings have not been loaded yet. This would require an AC core fix to change the loading order of the characters.

This is a minor issue since the character cannot ever equip any items like that in the first place, but to be aware of this issue.

ZhengPeiRu21 commented 1 year ago

Thank you for the report - I appreciate you spend time to look into this. Because this would require a large core change to fix and doesn't have any impact, I think I will mark this as will not fix, but it is good to be aware of this issue.