ZhengPeiRu21 / mod-individual-progression

AzerothCore Individual Progression Module
MIT License
111 stars 53 forks source link

patch-V and stealth ranks not working #194

Open DrNefarius opened 10 months ago

DrNefarius commented 10 months ago

Hey, so I installed individual progression on my server with enabled rogue skill restoration, so with poisons and multiple ranks of stealth. While I see the new poison skills in the trainer menu, i dont see multiple ranks of stealth, just the normal one. Also the Tooltip doesn't seem right, since the Tooltip for "Stealth" says that it reduces movement speed by 15% but it actually reduces by 30%. I've put all dbc files into the data/dbc folder on the server, overwriting the existing ones (4 in total) and i've put the patch-V file into my Data folder from my client.

image image image
DrNefarius commented 10 months ago

So I figured out what the issue with the tooltip was - i had another copy of patch-V inside /Data/enUS/ instead of just /Data/ and that seemed to have caused the problem with the text. I removed the copy from /Data/enUS/ and now the tooltip says 30% and it is 30%. But still no luck with the multiple ranks of stealth.

image

The first one says 30% (This one i learned at a normal rogue trainer) The second one 40% Then 35 and the last one says 30% again.

Grimfeather commented 1 week ago

Been looking into this today.

From my understanding the spell_dbc database is supposed to overwrite the server spell.dbc file I looked inside the server data/dbc/spell.dbc file. The information there is NOT correct. Rank 1 should be 50%, not 30% as it's stated in the spell.dbc file in the server files. Same goes for spell.dbc, inside the patch-V file. (edit: although I now think rank 1 was set to 30% because the different ranks are not working correctly yet, so you don't have to deal with -50% speed forever, because you can't learn ranks 2, 3 and 4 at a trainer)

It's weird though, because in the database spell_dbc stealth (rank 1) was set to 50% reduction. So the overwrite doesn't work.

After updating the spell.dbc file for the server and inside patch-V it now shows the correct information for Stealth (rank 1). But I still haven't figured out why the trainer is not showing rank 2, 3 and 4.

rank 2, 3 and 4 are inside spell.dbc and patch-V, so that's not it. also tried to make a clone of a rogue trainer and added the stealth spells to it, but only rank 1 showed up on the clone as well. Another issue is that when you learn rank 2 manually, it doesn't replace rank 1. you'll have 2 stealth buttons. you have to manually unlearn rank 1.

Grimfeather commented 1 week ago

The solution here may be to turn the new stealth spells into spell books. just like grimoires for warlocks leave spell 1784 alone so it doesn't mess with anything else like npcbots and playerbots create 4 new spell books and let the rogue trainers sell those.

I'll try that.

edit: an update on that idea. the rogue trainers refuse to be a vendor. no idea why there are other npcs that are both a vendor and trainer, so it should be possible, but something is blocking it.

edit2: I did end up figuring it out. I had to update gossip_menu_option as well to add the trade option.