ZhengPeiRu21 / mod-individual-progression

AzerothCore Individual Progression Module
MIT License
104 stars 43 forks source link

Naxx40: Construct, Plague, Military, trash adjustments #257

Closed sogladev closed 2 months ago

sogladev commented 2 months ago

Fixes

Some shared issues https://github.com/ZhengPeiRu21/mod-individual-progression/issues/70

Bosses Construct

Trash Plague Quarter

Military Quarter

Construct Quarter

GM commands to help test

attunement - reputation honored - complete quest

.mod reputation 529 10000
.quest complete 9121
.go creature 54192

teleport to naxx entrance inside strat

.go xyz 3960 -3392 121 329

reset instance

.instance unbind all

10man HC

/script SetRaidDifficulty(4)

go Thaddius

.go c 130957

4H door

.gobject activate 65753
.go c 130961

patchwerk

.go c 128135

Tools used

Look in CPP or smartAI with Keira3 https://github.com/azerothcore/Keira3

https://github.com/stoneharry/WoW-Spell-Editor

2 WoW-Spell-Editors side by side to compare 335 and 112

SmartAI CMangos 1.12

cmangos db, cmangos core,

https://github.com/BAndysc/WoWDatabaseEditor

Database Editor smartAI -> write smartAI with Keira

Exploring DBC Spells.

https://github.com/azerothcore/SpellWork

What's left todo, not in this PR

Client side patch:

ZhengPeiRu21 commented 2 months ago

Thank you for your continued fixes! Please let me know when your work here is done and I will test then merge.

sogladev commented 2 months ago

Thank you for your continued fixes! Please let me know when your work here is done and I will test then merge.

I'm working my way through the naxx instance and updating https://github.com/jellemeeus/mod-progression-system-naxx25-60/tree/naxx

I'll share changes soon since it's similar files

sogladev commented 2 months ago

I went through Naxx (Plague, Military, Plague Quarter) and aimed to reduce the damage of the wrath spells. I did fixes to pathing of Patchwork/Bony Constructs plus some others that I encountered. There should be minimal amount of custom spells, just for a summoning. Feugen casts an AoE mana burn, the visual is missing. Some others like Razuvious likely need a client patch to do the Disrupting Shout mechanic properly.

I'm continuing with spider/frost next

I don't know how you want to go about reviewing this? it's a bit much too untangle for seperate PRs

ZhengPeiRu21 commented 2 months ago

Thanks again for your work. Having it in a single PR is fine. As much as possible, I'd like to avoid the requirement for a client patch, even if that means we're not able to reach 100% accuracy. I'd prefer to get as accurate as possible within the constraints of the WotLK client, even if it means having to make some small compromises (for example, in the Four Horsemen, the Mark of Mograine spell was replaced with the Mark of Rivendare, so it currently has the wrong name and visual.) Please let me know if you feel otherwise; I'm open to options.

sogladev commented 2 months ago

A first priority is to get the scaling/spells down to vanilla levels to make the raid more playable. I try to avoid a client side patch as well as it brings extra challenges. It's also a hassle to work with and from what I've seen, it can be done without just fine. As I went through I noted where a patch would be useful or even required to achieve the accurate feel of naxx40. To me, it is future work but it's important to note spells/mechanics to do any potential polishing later. As of now I don't feel it to be necessary

sogladev commented 2 months ago

I updated the comment to show what fixes are included in this PR

ZhengPeiRu21 commented 2 months ago

Thank you once again for all of these fixes!