search

ZhengPeiRu21 / mod-playerbots

AzerothCore Playerbots Module
MIT License
193 stars 92 forks source link

GetTargetIcon(int index) API changed to GetTargetIcons()[int index] #175

Closed xuanfeng66 closed 1 year ago

xuanfeng66 commented 1 year ago

631863c540.patch

htc16 commented 1 year ago

@ZhengPeiRu21

ZhengPeiRu21 commented 1 year ago

Fix applied in https://github.com/ZhengPeiRu21/mod-playerbots/commit/4abe553f2743f43e774a4c8f322398195afc7a32. 谢谢@xuanfeng66! ^_^

htc16 commented 1 year ago

image

from this last update we have an error that Group would not be declared. I'm just trying to see here in the log which file is missing the statement

@ZhengPeiRu21

ZhengPeiRu21 commented 1 year ago

Sorry, I should have checked this more thoroughly before committing the patch. I don't see why it is necessary to change this API - what is the reason for the patch?

htc16 commented 1 year ago

actually, i even tried to check groups.h and it seems to me that there is no change in azerothcore source.

ZhengPeiRu21 commented 1 year ago

actually, i even tried to check groups.h and it seems to me that there is no change in azerothcore source.

Yes, I assumed this was a change to support a changed upstream API, but this is actually our own custom method to expose a normally private member needed by the bots, so this should not need to be changed.