search

ZhengPeng7 / BiRefNet

[CAAI AIR'24] Bilateral Reference for High-Resolution Dichotomous Image Segmentation
https://www.birefnet.top
MIT License
322 stars 28 forks source link

issues with the training Code #14

Closed rishabh063 closed 3 months ago

rishabh063 commented 3 months ago

Hey was starting my training ,

I just noticed some issues with the code quality .

like having self.sys_home_dir = '/root/autodl-tmp' or self.data_root_dir = os.path.join(self.sys_home_dir, 'datasets/dis')

these kind of things make it hard to quickly start the training and one had to just dig into the code find the issues

ZhengPeng7 commented 3 months ago

Hi Rishabh, To be honest, that's kind of the first thing in every project. I've made almost all of them in config.py with only one appearance instead of most other projects, where you need to modify this kind of thing in many places for the definition among many Python files.

ZhengPeng7 commented 3 months ago

I'll further make up the config file to put these kinds of things at the beginning.