search

Zhengjun-Du / Convexhull-based-Image-Recoloring-GUI

A GUI written by Qt for convex hull palette based image recoloring
11 stars 4 forks source link

The code for "Calc MVC" is different with paper "Mean Value Coordinates for Closed Triangular Meshes" . #1

Open qivigor opened 3 years ago

qivigor commented 3 years ago

Hi, thank you for your generous sharing. As shown in the pseudo in the paper, the code in in data.cpp "sintheta[i] d[vids[(i + 2) % 3]] d[vids[(i + 1) % 3]]" should be "sintheta[i] l[(i + 2) % 3] l[(i + 1) % 3]" . Or, are they equivalent?

Zhengjun-Du commented 3 years ago

@qivigor I think they are the same thing, or you will see the incorrect recoloring results.

Zhengjun-Du commented 3 years ago

or you can see my chinese blog about MVC: https://blog.csdn.net/u011426016/article/details/116569226

qivigor commented 3 years ago

@qivigor I think they are the same thing, or you will see the incorrect recoloring results.

I see the different recoloring results, and your result is better than my re-implementation of the original paper in which I use l instead of d. So finally I implemented the algorithm in python with reference to your code. Thanks again！