Open Mister-Hope opened 4 days ago
commitlint Replace ts-node with cosmiconfig-typescript-loader package https://github.com/conventional-changelog/commitlint/pull/3722
Although the speed has improved, The cosmiconfig-typescript-loader package added ,cz-git and czg will double the size, and I am still considering it. πΆβπ«οΈ This makes me wonder the TypeScript support is important. If it's just type support, the issue #193 also can do?
commitlint.config.ts
is supported by commitlint directly, so the docs need to be corrected, there is nothing to do with your pacakgecz.config.ts
supported, you should externalize cosmiconfig-typescript-loader
, tools like rollup and tsup can do that easilyBesides, I think you have misunderstood my original issue complaining about the deps number.
Since your package is strongly relying on commitlint, so you should try to reuse package that is required by it as much as possible while keeping the same major, this way you can externalize them safely as they are supposed to be installed to workspace anyway. (e.g.: cosmiconfig-typescript-loader
)
The main target for tool package like this is trying to avoid requiring any new package that is heavy. A package is heavy means that it has too many deps or a lot of unused features for your usage. You can try to bundle packages with cz-git, only if they:
Thank you for your reply.
commitlint.config.ts
Please feel free to point it out.
Since your package is strongly relying on commitlint, so you should try to reuse package
@commitlint/load
package have too many dep package.json. I have try but cjs project treeshakable effect is not wellnpx
bunx
usage), should resolve the ts configuration file at this time, I will keep an open opinion and will not add it in the short term.However, I don't understand with my documentation not supporting commitlint.config.ts Please feel free to point it out.
No offense, but as I am pointing out the link in issue body, it should not be hard to find these.
Done Btw, I will try to configure loading for TypeScript using node > 22 LTS (2024-10-29), instead of adding extra dependencies.
β Checklist
π System Info
π Description
See https://commitlint.js.org/reference/configuration.html
So https://cz-git.qbb.sh/config/#typescript-template should be fixed
π Reproduction link / repo:
No response