search

Zhengwinter / pe

0 stars 0 forks source link

Exception thrown and program crashes when trying to find free times within a day filled with 3 tasks #8

Open Zhengwinter opened 4 months ago

Zhengwinter commented 4 months ago

image.png

An unhandled exception was thrown and program crashes when the user attempts to find the free time for a day with 3 events. The exception in question was a "DateTimeParseException".

This could have potentially been caused by the accepting of an invalid date earlier on.

nus-pe-script commented 4 months ago

Team's Response

This issue only occurs if invalid date is input.

Majority of users will put in valid dates, and will not reach this error, hence should be of medium severity.

Items for the Tester to Verify

:question: Issue severity

Team chose [severity.Medium] Originally [severity.High]

Reason for disagreement: I disagree with the argument that the majority of user would not reach this error.

Firstly, although there is instructions within the user guide about the format of the input date, the is no explicit instruction in the program about it, increasing likelihood of incorrect dates being entered due to ignorance of the format.

Secondly, the program accepts invalid dates, which means even an unintentional mistake when entering the date can lead to this exception.

Hence, the fact that there are very plausible paths for this exception to occur and crash the program means that it should be of high severity.