ZhengyaoJiang / PGPortfolio

PGPortfolio: Policy Gradient Portfolio, the source code of "A Deep Reinforcement Learning Framework for the Financial Portfolio Management Problem"(https://arxiv.org/pdf/1706.10059.pdf).
GNU General Public License v3.0
1.74k stars 750 forks source link

features besides ohlc #21

Closed huminpurin closed 6 years ago

huminpurin commented 6 years ago

I'm not familiar with reinforcement learning so this might be a newbie question. In other areas of data science, feature engineering can significantly affect the performance. As for quantitative trading, indicators (generated from ohlc data) like MACD usually can improve the performance of models. I would like to know did you use only ohlc prices for features on purpose (maybe it's not necessary in case of reinforcement learning) or is this considered as future work?

dexhunter commented 6 years ago

did you use only ohlc prices for features on purpose

Quote from our paper:

Nonetheless, all relevant information is believed, in the philosophy of technical traders (Charles et al., 2006; Lo et al., 2000), to be reflected in the prices of the assets, which are publicly available to the agent.

OHLC data is basically direct information and reflection from market, and most indicators are also generated from ohlc data as you said. So I think those information is probably enough for the agent. I also think we will test integrating indicators to the framework to see if better results are achieved, even though I doubt it's just a repeat of same information (or probably have a different emphasis).

huminpurin commented 6 years ago

Thanks! It looks like i missed that part in your paper.