Open dlacombejr opened 6 years ago
@dlacombejr Hi! Thanks for the PR. I don't quite understand why training
input
trading
are included in the network of new config? I think only layers
needs to be changed if testing which network architecture is better.
@DexHunter I guess my intention was really to allow there to be changes to any aspect of the configuration, not just network architecture. This approach leads to lengthy configuration files, but full access to any change in configuration (configurations that are undesired can be commented out because I load them using commentjson
-- which I've added to requirements.txt
. I suppose the configuration could be set up to support iterating over lists of training
, input
, trading
and layers
dictionaries as in a grid search, but this could blow up pretty quickly and you may only want certain combinations. Even though the current approach is more error-prone (e.g., if I want to just change layers
between two configs but training
is accidentally different), I think it is still preferable because there is full control. If it makes more sense, we can change the networks
key to configs
or something.
Thanks for your contribution again!
Adding support for additional layers such as Batch Normalization and ReLU
Yes, this makes sense.
Support for multiple pre-configured networks in net_config.json. For example, now net_config.json can look like the following:
This implementation is conflict with our automatic hyper-parameters optimization architecture, which is not currently open sourced but it might be released in future. My suggestion is to configure searching space in a separate file or maybe inside generate.py as a temporal solution of grid search.
And it would be nice if you can push the new "dev" branch instead of the master branch.
@ZhengyaoJiang, will you be releasing a hyperparameter optimiser? I've seen Bayesian Optimizers work better for this task over grid search or random search
Major changes include:
net_config.json
. For example, nownet_config.json
can look like the following:The original
net_config.json
is still supported.