search

ZhengyaoJiang / PGPortfolio

PGPortfolio: Policy Gradient Portfolio, the source code of "A Deep Reinforcement Learning Framework for the Financial Portfolio Management Problem"(https://arxiv.org/pdf/1706.10059.pdf).
GNU General Public License v3.0
1.74k stars 750 forks source link

updated Readme and User Guide #81

Closed ghego closed 6 years ago

ghego commented 6 years ago

Hey @ZhengyaoJiang I've updated the readme and user guide to reflect the current version of the library. Please have a look and let me know if I missed anything or if there are other things that need improvement.

I mostly simplified the explanation and made it clearer where I thought there were ambiguities.

ghego commented 6 years ago

I've also fixed a bug that would crash the plotting function if no display was found and updated the required packages

dexhunter commented 6 years ago

@ghego Thanks for the PR. Although we did convert most algorithms from matlab to python for OLPS, it is not our intention to highlight the traditional algorithms but rather our drl approach. So I don't think it's necessary to add so many explanations for traditional algorithms. But still, thanks for the PR.

ghego commented 6 years ago

Understood. I ended up adding a few more changes to clean up the code as well. I think it's important to have a bit of information about the other algos. maybe I can move it to a different Readme file inside the traditional algo folder?

dexhunter commented 6 years ago

maybe I can move it to a different Readme file inside the traditional algo folder?

Sure, thanks. I think @ZhengyaoJiang will merge later.

ghego commented 6 years ago

done. moved explanation to separate readme

ZhengyaoJiang commented 6 years ago

Thanks for your contribution.