ZhiWei1010 / pe

0 stars 0 forks source link

Major can be only filled with only integers #6

Open ZhiWei1010 opened 6 months ago

ZhiWei1010 commented 6 months ago

Currently the major field is set to be able to take any values, which can be stricter in checks.

This is weird and might cause confusion when user mixes up say phone number field and major field when adding many students at once and set phone number as student's major!

Maybe a warning message would be good to let users know that the major field is of suspicious input!

not a major issue

image.png

nus-se-script commented 6 months ago

Team's Response

Thank you for raising this, the idea of having a "suspicion" and stricter check for major is a suggestion that we can consider. Also, the argument for a user mixing up phone number field for major field could be extended to mixing up any field, like name with tags. this way, there is boundless arguments for this. Therefore the team opines that this is out of scope, though a good suggestion of stricter checks for major.

The reason why this is out of scope is because implementing suspicion and validation checks isn't as straightforward and easy, when there are use cases for certain symbols and numbers in major.

Side Note: The title of this bug report is misleading.

Items for the Tester to Verify

:question: Issue response

Team chose [response.NotInScope]

Reason for disagreement: [replace this with your explanation]