Zhilin-Huang / pe

0 stars 0 forks source link

Wrong response punctuation when no food in database #10

Open Zhilin-Huang opened 4 years ago

Zhilin-Huang commented 4 years ago

Screen Shot 2020-04-15 at 12.58.05.png

The response still uses a ':' followed by nothing when there is no food in database.

nus-pe-bot commented 4 years ago

Team's Response

Rejected as bug does not affect the usage of the product since it is still crystal clear to the user, what is or isn't stored in the database.

Items for the Tester to Verify

:question: Issue response

Team chose [response.Rejected]

Reason for disagreement: This is definitely a bug because it really made me wonder what is happening when nothing is followed after the application states These are the foods stored in our database:. This is far from 'crystal clear'. The semicolon : naturally indicates that something should follow after it and user would expect to see something to be displayed after it. Instead of using These are the foods stored in our database: followed by nothing which confuses the users, wouldn't it be better to just respond with There is nothing in our database?

This can be considered as at least one of 'Minor typos and grammar errors', which is a bug.