Zhouyirui / pe

0 stars 0 forks source link

Unclear Error Message for Edit #6

Open Zhouyirui opened 2 years ago

Zhouyirui commented 2 years ago

On entering edit 9999999 n/Shanna, or edit 999999, the error message does not inform the user the INDEX is out of bounds.

Expected: Error message inform the user that the INDEX is out of bound

Actual:

image.png

image.png

nus-pe-bot commented 2 years ago

Team's Response

Multiple bugs have been raised in this issue. The ambiguous error message for edit 9999999 n/Shanna has been chosen. Reason being:


Issue is a duplicate of #4615, where the issue raised was that an out of bound index did not provide an accurate enough error message for view. Both view and edit make use of the same error message, hence the duplicate behavior.

The 'Original' Bug

[The team marked this bug as a duplicate of the following bug]

Unclear error message for view

On viewing a student with an INDEX that is out of bounds (view 12 T), the error message displayed informs the user that the selection is invalid. The error message does not inform the user of exact source of the incorrect input, and is unclear.

Expected: The error message informs user the INDEX selected is out of bounds.

Actual: image.png


[original: nus-cs2103-AY2122S1/pe-interim#4561] [original labels: type.FeatureFlaw severity.VeryLow]

Their Response to the 'Original' Bug

[This is the team's response to the above 'original' bug]

The wrong error message was printed for invalid index. Accepted.

Items for the Tester to Verify

:question: Issue duplicate status

Team chose to mark this issue as a duplicate of another issue (as explained in the Team's response above)

Reason for disagreement: [replace this with your explanation]


:question: Issue type

Team chose [type.FeatureFlaw] Originally [type.FunctionalityBug]

Reason for disagreement: [replace this with your explanation]