search

ZhuangLab / storm-control

Microscope control software
Other
66 stars 68 forks source link

Fixed a bug introduced in the most recent version of tifffile #112

Closed jeffmoffitt closed 3 years ago

jeffmoffitt commented 3 years ago

The most recent version of tifffile changed a default setting for saving tiff files. Now the contiguous setting is assumed to be False unless otherwise specified. In this pull request, I assign the contiguous flag to True (the former default) in imagewriters.py.

HazenBabcock commented 3 years ago

Older versions of tifffile include this keyword? Or they will break?

jeffmoffitt commented 3 years ago

Older versions include this keyword. Tifffile changes the default from True to False. So my proposed change should work with any version of tifffile.

On Sat, Jan 2, 2021 at 5:22 PM Hazen Babcock notifications@github.com wrote:

Older versions of tifffile include this keyword? Or they will break?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ZhuangLab/storm-control/pull/112#issuecomment-753537224, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAUJAXH2RROHXDRDKRIM3LLSX6MBZANCNFSM4VP3NFSA .

HazenBabcock commented 3 years ago

Sounds good. Merge at your convenience. Thanks!

jeffmoffitt commented 3 years ago

Perfect! Thank you!