search

ZhuangLab / storm-control

Microscope control software
Other
65 stars 67 forks source link

Python3 pyqt5 #64

Closed emanuega closed 6 years ago

emanuega commented 6 years ago

Added some previously unlisted dependencies in the installation documentation, fixed small bugs from the change to Python3/pyqt5, and switched the gain for the focus lock feedback loop to be a parameter.

HazenBabcock commented 6 years ago

Thanks!

My thinking for not having the gain be a parameter was that it was not obvious to me that having the casual user be able to adjust it was a good idea. At least in theory, at that level of the focus lock everything is in units of microns (or something.. I've kind of forgotten already.. ), so there would hopefully be a best value that was basically setup independent. Then details about the settings for the best performance, etc. would be part of whatever pieces of hardware were actually doing the work.

Can you comment on why you think it should be adjustable? And not for example hard coded, or a property in the config.xml file?

emanuega commented 6 years ago

Looking at it more closely, I agree that the gain parameter I added appears to be redundant with the units_to_microns parameter for the focus lock camera and shouldn't be necesary.

I initially added the gain parameter to easily change the sign of the gain since my z stage seems to move in the opposite direction in response to a voltage increase, but a better solution would be for me to implement a class for my piezo stage that can make it behave consistently with the MCL controller.

HazenBabcock commented 6 years ago

Yeah, that is definitely a detail that is better handled by the z stage hardware class. At the level of lockModes all the stages should behave the same. This also simplifies z scans, etc.