ZhuangLab / storm-control

Microscope control software
Other
65 stars 67 forks source link

Invalid command generated when Dave requests a parameter that has not been initialized #79

Closed jeffmoffitt closed 6 years ago

jeffmoffitt commented 6 years ago

Dave generates an invalid command when validating a command for set parameters if that parameter has been loaded into hal but not yet selected.

This issue may arise from the extra time that hal requires to initialize the parameter when it is activated for the first time.

jeffmoffitt commented 6 years ago

As an additional aspect of this issue, Dave with crash when a second attempt is made to validate a sequence after this issue occurs. Otherwise, Dave is capable of validating a sequence that has previously failed to validate (either due to a missing parameter or existing file).

HazenBabcock commented 6 years ago

Could you post the trace back(s)?

jeffmoffitt commented 6 years ago

There is no trace back. Dave simply mistakes a valid command for an invalid one.

Dave then freezes when validation is run again. And, unfortunately, there is no trace back either.

Best Jeff

On Sat, May 12, 2018, 8:57 PM Hazen Babcock notifications@github.com wrote:

Could you post the trace back(s)?

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/ZhuangLab/storm-control/issues/79#issuecomment-388593518, or mute the thread https://github.com/notifications/unsubscribe-auth/ACiQXDYWWQRQtwJjCKSkT9StSXR8N3rkks5tx4TugaJpZM4T8jAO .

HazenBabcock commented 6 years ago

Does it work properly if you set 'parallel_mode' in tcp_control to False?

HazenBabcock commented 6 years ago

Ignore the above. This might be related to #84? If not I'm going to need a simple action sequence that duplicates the problem, or an in person demonstration of the problem.