search

ZhuangLab / storm-control

Microscope control software
Other
66 stars 68 forks source link

Hal crashes when Dave tries to change parameters #84

Closed emanuega closed 6 years ago

emanuega commented 6 years ago

When Dave sends a command to set parameters to parameters that are not currently selected, Hal crashes. This happens only when Dave is sending the real command and not when Dave is validating the command.

The output text from the command prompt is reproduced below:

TCP message received: Message Type: Take Movie error: False error_message: None message_data: {'name': 'Epi-750s7-650s7-560s1_0', 'length': 15, 'min_spo ts': 0, 'parameters': 'Epi-750s7-650s7-560s1', 'overwrite': False} message_id: 11 response: {} test_mode: False

feeds 'parameters changed' tcp_control 'set parameters'

Got an exception from 'settings' of type ''set parameters' received while locked out.'!

Traceback when the exception occurred: Traceback (most recent call last): File "C:\software\storm-control\storm_control\hal4000\halLib\halModule.py", li ne 259, in nextMessage self.processMessage(message) File "C:\software\storm-control\storm_control\hal4000\settings\settings.py", l ine 325, in processMessage raise halExceptions.HalException("'set parameters' received while locked out .") storm_control.sc_library.halExceptions.HalException: 'set parameters' received w hile locked out.

HazenBabcock commented 6 years ago

I think you were making two requests to change the parameters back-to-back?

I fixed one bug where HAL would tell the client that it was ready for next command after a parameters change when in fact it was not. I think this will solve your issue based on your description. If not can you please e-mail me the Dave XML file so that I can more easily duplicate the sequence of actions that are causing this behavior?

emanuega commented 6 years ago

That fixes my problem. Thanks.