search

ZhuangLab / storm-control

Microscope control software
Other
66 stars 68 forks source link

mosaic flip/transpose not working #91

Closed BogdanBintu closed 5 years ago

BogdanBintu commented 5 years ago

In Hal4000 when editing a parameters xml, from the mosaic tab when changing the flip horizontal/vertical and transpose from False to True nothing happens. These variables are dummies.

HazenBabcock commented 5 years ago

Not sure what you mean. The current values should be saved in the movie XML that Steve will read when it loads the movie to display. It is true that they don't do anything in HAL. If you want to change the orientation of the HAL display then you need to change the values in camera section of the hardware XML file. These cannot be changed using HAL's editor. The idea was that you'd set them once to match the X/Y convention of the stage.

BogdanBintu commented 5 years ago

mosaicTab

Variables flip_horizontal, flip_vertical and transpose are dead.

HazenBabcock commented 5 years ago

Dead? I think what you meant to say is that when you press 'update' the values reset to their initial value. Yes this is an issue and thank you for pointing it out. What I think should happen is that these parameters should not even be displayed in the editor as they are not actually editable. They should be set correctly in the hardware XML file.

HazenBabcock commented 5 years ago

FWIW, only the 'objective' parameter is actually editable.

BogdanBintu commented 5 years ago

Great. Sorry, I got confused what is the indented way to change the flip and transpose properties. I agree with you, it is more natural for these to be hardware settings dependent on the scope. Thanks for clarifying, problem solved.

HazenBabcock commented 5 years ago

Okay I will fix this so these parameters don't appear in the editor. Please leave this issue open as a reminder.

HazenBabcock commented 5 years ago

This should be fixed now, sorry for the confusion.