search

ZhuangLab / storm-control

Microscope control software
Other
66 stars 68 forks source link

Steve positions are not compatible with Dave #93

Closed BogdanBintu closed 5 years ago

BogdanBintu commented 5 years ago

On Windows machines, upon saving the positions selected in Steve, a new line is added between positions. This causes Dave an error when trying to read the empty lines in the positions file saved by Steve.

HazenBabcock commented 5 years ago

This used to work.. Steve is adding a "\r\n" to each line so that if you load the text file in notepad it will display correctly. Anyway at least two problem here.

  1. The docs say that one should always use "\n" when writing text (see os.linesep).
  2. Dave should ignore blank lines. It is easy to accidentally add a trailing blank line to the list with a text editor and this will also mess things up.

My preference would to fix (1) in the 'steve_v2' branch, merge this and then fix (2). However as far as I know no one has done any testing on this branch besides me..

HazenBabcock commented 5 years ago

This should be fixed as of 2e11e1b6d42f1e76c268de2030d8884223e2bd72.

HazenBabcock commented 5 years ago

Reopen if this continues to be a problem.