search

ZhuangLab / storm-control

Microscope control software
Other
65 stars 67 forks source link

Implemented fluidics interface for syringe pump. #98

Open seichhorn opened 4 years ago

seichhorn commented 4 years ago

I'd like to get back onto master, can these be merged or are additional changes needed?

emanuega commented 4 years ago

These can be merged as long as they don’t break the functionality of the peristaltic pump. I don’t have a peristaltic pump available to test.

seichhorn commented 4 years ago

I'll test this afternoon

jeffmoffitt commented 4 years ago

Let me also pull this branch and test it on my systems before we merge it. I should be able to run this test tomorrow.

seichhorn commented 4 years ago

This worked fine for my peristaltic pump, there's a minor issue where it wasn't able to parse the default_config.xml file that it attemps loads upon open, I'm trying to trace down why that is and resolve it, but it parsed the protocol/valve config file I use without issue/changes and ran through the protocols properly.

HazenBabcock commented 4 years ago

@emanuega @jeffmoffitt Is this okay to merge?