search

Zhuinden / flowless

[DEPRECATED] Based on Flow 1.0-alpha. To keep your life simple, use zhuinden/simple-stack instead.
Apache License 2.0
141 stars 7 forks source link

Consider adding means to add global State, not bound to history keys #20

Closed Zhuinden closed 7 years ago

Zhuinden commented 7 years ago

The Activity should also be able to store state inside Flow, define its key but not be part of history (because it always exists).

How should this be done?

Should this be done?

Otherwise it should be "ROOT" key, but that doesn't really simplify things for the dispatcher at all.

Zhuinden commented 7 years ago

Would solve https://github.com/Zhuinden/ExampleGithubClient/issues/2 to access State of global presenter in dispatcher via non-history key

Zhuinden commented 7 years ago

fixed by https://github.com/Zhuinden/flowless/commit/3aeb53146ba42fa6e6ab9b8955ec5bcd02450ad6

Zhuinden commented 7 years ago

That's great that you can add state, but you cannot access it anywhere.

It also cannot be persisted.

Joy.

Zhuinden commented 7 years ago

Fixed by https://github.com/Zhuinden/flowless/commit/e1b3191952654abb5370aab3a70d5838f4a0136e , https://github.com/Zhuinden/flowless/commit/39d5175ec35c66bdfd2d24ad243cfd20d5abf89e and https://github.com/Zhuinden/flowless/commit/6ca4222397cd1328925b7a94a21e9d9b82f40399