search

Zhuinden / simple-stack

[ACTIVE] Simple Stack, a backstack library / navigation framework for simpler navigation and state management (for fragments, views, or whatevers).
Apache License 2.0
1.37k stars 74 forks source link

Consider a massive renaming for things like Key and State* #161

Closed Zhuinden closed 5 years ago

Zhuinden commented 5 years ago

There's a chance that the API would be much easier to work with if I used the term Screen instead.

Interestingly, Flow 0.8 and before also used the term Screen for what is called Key now.

That would mean

ScopeKey and ScopeKey.Child are a good question, though.

Zhuinden commented 5 years ago

Other option:

Zhuinden commented 5 years ago

Another option:

State and Key becomes ScreenKey

Although maybe it really should just stay Key

also KeyParceler wants to be ObjectParceler.

Zhuinden commented 5 years ago

Okay, so what it's gonna be is:

StateChange.getNewState() -> stateChange.getNewKeys() topNewState() -> topNewKey() (same for previous)

also: StateKey -> DefaultViewKey DefaultStateChanger -> DefaultViewStateChanger

and the ViewChangeHandler.CompletionCallback is often in my way, I'll give a different name for that, too.