Fix that lookups did not consider scopes not accessible in latest navigation history

Zhuinden / simple-stack

[ACTIVE] Simple Stack, a backstack library / navigation framework for simpler navigation and state management (for fragments, views, or whatevers).

Apache License 2.0

1.36k stars 76 forks source link

Fix that lookups did not consider scopes not accessible in latest navigation history #200

Closed Zhuinden closed 4 years ago

Zhuinden commented 4 years ago

Fixes #198

Problem was that the explicit parent scope hierarchies were rebuilt based on the latest navigation keys.

This however means that during a lookup, not all available scopes were considered.

However, this is still a WIP, because any lookup (including findScopesForKey) are still based on latestKeys, and a failing test + fix should be added for those as well. ALL scopes should be accessed during lookup, not just the ones available from the current latest navigation history.

Zhuinden commented 4 years ago

This actually increases the minSdk requirement to API 9, because of AbstractMap.SimpleEntry.

How sad. 😢

Anyways, apparently all old and new tests work.