search

Zhuinden / simple-stack

[ACTIVE] Simple Stack, a backstack library / navigation framework for simpler navigation and state management (for fragments, views, or whatevers).
Apache License 2.0
1.36k stars 76 forks source link

Verify that the latest changes to `findScopesForKey` work if a key is ScopeKey.Child, but not ScopeKey #201

Closed Zhuinden closed 4 years ago

Zhuinden commented 4 years ago

I have a nagging feeling that I can break the change in https://github.com/Zhuinden/simple-stack/pull/200/files#diff-f22f740b8aa793aa6fd2089ced3541dbR138 with the aforementioned scenario, and will investigate this accordingly.

Zhuinden commented 4 years ago

Should also verify that if a key is not a scope key in any way, then it'll most likely just get an empty list of scopes back :thinking:

To think the tests successfully ran over it, I guess they were set up only for the happiest path, huh. :roll_eyes: