search

Zhuinden / simple-stack

[ACTIVE] Simple Stack, a backstack library / navigation framework for simpler navigation and state management (for fragments, views, or whatevers).
Apache License 2.0
1.36k stars 76 forks source link

Examples should either be updated, pruned, moved, or deleted #222

Closed Zhuinden closed 3 years ago

Zhuinden commented 4 years ago

There are 13 examples and some of them are inherited from android/architecture-samples, therefore ridden with notorious practices. And as they are in my repo, one could think that they represent the library.

I expect I should:

✅ 1.) move all examples into some examples subfolder

✅ 2.) try to bring the https://github.com/Zhuinden/simple-stack-tutorials repo into a tutorials subfolder

✅ 3.) Create default library for Fragment navigation along with Kotlin extension functions ( https://github.com/Zhuinden/simple-stack/commit/dbc3ff12a42fa92ae95d2beba1d306ff2fb1c0ee )

✅ 4.) Update wiki

✅ 5.) Actually update ALL samples to use the extensions instead of just advanced-samples/extension-sample (done in https://github.com/Zhuinden/simple-stack/commit/bbbda5327ae4f10fb6fe921fd07b069ed7fa0e2a , https://github.com/Zhuinden/simple-stack/commit/c7720170eeb13e3cb589c49e31054de5f9f5f3f7 and https://github.com/Zhuinden/simple-stack/commit/ca81597403927393aad56acb5f3629af951390b3, legacy done in https://github.com/Zhuinden/simple-stack/commit/1b430bce93b791f3745c3dc8608f22224a8cd118 and https://github.com/Zhuinden/simple-stack/commit/bd6a80e2c65e09387628dd9cef419112a3383a1e)

✅ 6.) possibly rewrite the code for the MVVM sample because despite multiple rewrites, it still has crazy things going on that were directly inherited from the Google samples (fixed in https://github.com/Zhuinden/simple-stack/commit/b8e00a27e4c5fd0ebe4d1d6c96b608d91af3582e)

( 7.) possibly create a shared element example for views? I've been putting that off for years now )

Currently it's a bit chaotic and it might put people off :disappointed:

Zhuinden commented 4 years ago

Progress is being made.

Zhuinden commented 3 years ago

MVVM sample is finally done: https://github.com/Zhuinden/simple-stack/commit/b8e00a27e4c5fd0ebe4d1d6c96b608d91af3582e

I can forget this for 2.5 years

Zhuinden commented 3 years ago

I probably closed this ahead of time, but with https://github.com/Zhuinden/simple-stack/commit/d4a41a70e9615aaac8bab0f8e61c2aac94a9e2bf it's definitely in a better state.

I'm kinda thinking maybe I should just remove Dagger from the MVVM sample too. Kapt is pain.