ZiWang55 / WhatsStreamin

App that allows user to query a movie they are interested in and return what streaming platform its on, if any.
0 stars 3 forks source link

Travis/ESLint Config Corrections #17

Open SirPotatoIV opened 3 years ago

SirPotatoIV commented 3 years ago
  1. The file name for your ESLint configuration file is currently incorrect.
    • The file name is currently eslintrc.json. It should be .eslintrc.json. You are missing a period at the start of the file name.
  2. The lint script in your package.json is probably okay, but I would recommend changing it the more specific script "lint": "eslint \"./**/*.js\""
    • Currently ESLint will check all files in your project because you have "eslint .". With the script I have listed above, it will only check JavaScript files.
  3. In your configuration for Travis-CI, .travis.yml, I would remove the spaces/tabs before the script: property.
ZiWang55 commented 3 years ago

Okay I've fixed the issues listed above. But when I go to TravisCI I activate the repo. It still shows no build? image

SirPotatoIV commented 3 years ago

Hmmm, that is frustrating. Would you mind adding me as a contributor to your repository so I can do some more digging?

ZiWang55 commented 3 years ago

Hmmm, that is frustrating. Would you mind adding me as a contributor to your repository so I can do some more digging?

Sure, I've added you.