ZiadJ / knockoutjs-reactor

Recursively tracks changes within a view model no matter how deeply nested the observables are or whether they are nested within dynamically created array elements.
Other
74 stars 22 forks source link

KO version check for minimized propery names (see #17) #19

Closed bago closed 9 years ago

bago commented 9 years ago

disposeWatcher used "child.H || child._subscriptions;" For every knockout version the minimized name changes breaking that code.

in 3.0.0 the minimized name is "F" in 3.1.0 it is "H" in 3.2.0 it is "M" in 3.3.0 it is "G"

So it seems the current code is only "fully" compatible with 3.1.0. I added field names for 3.0.0 to 3.3.0 versions and code to throw exceptions if the KO version is unsupported.

bago commented 9 years ago

Hopefully fixes #17