search

ZiadJ / knockoutjs-reactor

Recursively tracks changes within a view model no matter how deeply nested the observables are or whether they are nested within dynamically created array elements.
Other
74 stars 22 forks source link

Not Compatible with knockout 3.4 #34

Closed jrsearles closed 8 years ago

jrsearles commented 8 years ago

Knockout 3.4 was just released and this library breaks with the minified version.

crashnick16 commented 8 years ago

+1

ZiadJ commented 8 years ago

Ok, I'll fix it over the week. It's just that I'm super late on some other projects right now. The subscription name under v3.4 was changed so meanwhile you can fix it by adding case "3.4.0": subscriptionsField = 'NewFieldName'; break; to switch (ko.DEBUG || ko.version) { ... }. The field name in question can be identified while debugging and it is created right after calling .subscribe() on any observable. Somehow it keeps changing at every release of the minified version but I'd expect it to be a capital letter like before.

bago commented 8 years ago

It should be "K". I'll try to make a PR soon