search

Zibbp / tidal-utils

Convert Spotify playlists to Tidal playlists and more.
GNU General Public License v3.0
24 stars 1 forks source link

cleanup docker stuff #4

Closed Leptopoda closed 2 years ago

Leptopoda commented 2 years ago

Cleanup the Dockerfile and docker-compose.yml

Zibbp commented 2 years ago

The start.sh is a feature that I use and will not remove. I use the start.sh as part of my music archiving workflow using webhooks to fire events on success or failures of this container.

I don't believe adding the config is necessary to the repository. The application auto generates the config on run. If you believe it should be let me know.

Leptopoda commented 2 years ago

I staged the config by accident. I agree that it doesn't need to be in the repo.

Leptopoda commented 2 years ago

I don't think the script will be usefull by many.

In this case I'd rather use a local dockerfile like:

version: '3.3'
services:
  tidal-utils:
    container_name: tidal-utils
    build:
      context: ./tidal-utils
      dockerfile: Dockerfile
    volumes:
      - ./data:/data

and add a local dockerfile overwriting the cmd like

FROM image: ghcr.io/zibbp/tidal-utils:latest

COPY start.sh /exec/start.sh

RUN chmod +x /exec/start.sh

CMD ["./exec/start.sh"]

but I can see why you use the current approach :)