[Spell]Sweeping Strikes

[GoogleCodeExporter]

By pdx15 (18 February 2010 - automatically ported issue):

Sweeping Strikes http://www.wowhead.com/?spell=12328 stuck with Whirlwind 
http://www.wowhead.com/?spell=1680 ,however the such shouldn't be.
thx :)
Sorry for English :)

Original issue reported on code.google.com by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By worm:
Confirm, whirlwind shouldnt trigger proc sweeping strikes.

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By lovelol:
may you could check this
http://bitbucket.org/lovelol/oregoncore-lovelol-branch/changeset/18ed934aea77/

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By pdx15:
worm yes =)
lovelol cool :))

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By worm:
Thanks, i'm gonna try this change

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By niyo:
sweeping strikes also does too much dmg to the not targeted player

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By worm:
Maybe this can be useful
http://code.google.com/p/trinitycore/source/detail?r=04048b8e5e26

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By lovelol:
nah this wont help, if sb could test my version and confirm that it is working 
i could push it into the repo

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By oregon:

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

• Changed state: Accepted

[GoogleCodeExporter]

By niyo:
lovelol, your fix works, I tested it, please push it into the repo

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By lovelol:

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

• Changed state: Fixed

[GoogleCodeExporter]

By worm:
sry for late but it took quite a long time to test. since this change; ss is 
broken. it doesnt work at all

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By pdx15:
fix dont work?

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By niyo:
yea, sorry guys :C the fix broke the spell, i think there went something wrong 
at my tests, sorry again

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

• Changed state: Accepted

[GoogleCodeExporter]

By Anonymous:
confirmed broken SS after commit 84;

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By Anonymous:
confirmed broken ss after commit 84;

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By lovelol:
backport ;)

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By worm:
Maybe it's http://fr.wowhead.com/?spell=44949 instead

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By lovelol:
test it

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By worm:
it breaks ss too

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By oregon:
does this work at WOTLK branch trinity?

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By lovelol:
I never saw a warrior in wotlk doing whirwind

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By worm:
I've tried this
http://code.google.com/p/trinitycore/source/detail?r=c22ffbde03e9
But it also breaks ss...charges are consumed but no damage are dealt. I don't 
get it

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By pdx15:
yeeehh
http://s55.radikal.ru/i150/0912/67/798b3c23e287.jpg

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By lovelol:
check it

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By lovelol:
bump? i get feedback from pdx15 that it is working. screenshot needed.

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By pdx15:
http://radikal.ru/F/s42.radikal.ru/i097/1003/21/31f3f2a165f3.jpg.html

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By pdx15:
1.10.2
Whirlwind - When this ability is used with Sweeping Strikes, it will burn only 
one charge of Sweeping Strikes and will generate only one additional attack.
On screenshot it is visible that the warrior beats 4 purposes, after blow WW 
proc only one SS, actually as well as is written on wowwiki

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By pdx15:
Now doesn't work only - Stacks with Cleave, causing four attacks on two enemies 
every swing
In the rest works normally

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By lovelol:
check it :x

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By pdx15:
this? - Stacks with Cleave, causing four attacks on two enemies every swing
:)

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By lovelol:
yeah. i can't test my fix :)

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By pdx15:
ok, At night \morning I will unsubscribe =)
?????????????? =) thx

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By Anonymous:
on cleave, it uses 2 charges, on whirlwind is uses 1.

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By pdx15:
UP! =)
war SS Kills totems shamans :D
It isn't correct =)

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

By pdx15:
and http://bitbucket.org/oregon/oregoncore/changeset/31fca4b519af/ doesnt work 
):

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 2:53

[GoogleCodeExporter]

Original comment by stfxm...@gmail.com on 30 Dec 2010 at 6:01

• Added labels: Com-Spells_Skills_Talents

[GoogleCodeExporter]

Fixed here 
http://code.google.com/p/oregoncore/source/detail?r=e190d5d71e3c6f5285f6a83ed6b5
5f3c40d129eb

Original comment by dave...@gmail.com on 6 Aug 2011 at 9:29

• Changed state: Fixed