Zicore / TradingPostNotifier

Zicores Trading Post Notifier
11 stars 9 forks source link

Transaction lists still not updating properly. #9

Closed padmanek closed 9 years ago

padmanek commented 11 years ago

Example: You order Superior Sigil of Fire for 4g. Somebody outbids you 4g 1c -> You get a Notification and click OK You go to TP, cancel ur bid and put new one at 4g 2c Trading Post Notifier show's you have bids for 4g and 4g 2s and will keep bugging you that your bid for 4g is outbidded. Also your new bid for 4g 2c will have Notify "unchecked" under Buying Item list even if the whole tab has it checked. If the whole tab has Notify checked, all the added bids should have Notify checked by default.

Workaround> You order Superior Sigil of Fire for 4g. Somebody outbids you 4g 1c -> You get a Notification and click OK You go to TP, cancel ur bid. Now we wait until TPN updates Transaction list OR click Refresh. When its updated now you can make a new bid on 4g 2c. You go to TPN and uncheck & check again [Notify] You can also restart the program...

Exception: If the TPN happens to update Transaction List after you cancel the bug wont happen.

Quite annoying isnt it?

Also when on Buying Items List Notify is checked, all the new bids you put on TP are added unchecked. You have to uncheck & check Notify BUT you'll still get notifications that you bought those items even if they remain unchecked, only the bought notifications, sadly not Outbid ones.

Zicore commented 11 years ago

So in other words, I need to tell the TPN to refresh the transaction after every transaction happening or I need to check the specified item in the transactions/notifications and remove it after it's outbid.

Well I'll have a look.

padmanek commented 11 years ago

Well, it's easy to reproduce bug. 1.Order something 2.Make sure TPN has it in the Buying Items List 3.Cancel Order 4.Order the same thing with diffrent price

If TPN doesn't update itself between step 3 & 4 the bug will occur.

I order very fast, copy/paste from gw2spidy and ordering on TP takes me 6-7sec.

I dont know how to help you. When you press "Refresh" he should completely wipe the Buying List and pull new one from TP. Looks like he's not clearing it.

Also can u make sure that if "Notify" in the whole list is checked, all the newly added items have "Notify" checked aswell?

Zicore commented 11 years ago

When I clear the list on every update, you'd have ugly list updating and waiting.

padmanek commented 11 years ago

The function SearchResult(e.Value, e.Arg.ToString(), e.Uri, JsonResultType.Transactions, e.TransactionType); is bugged. If you order 10 items for 1s 90c and 15 items for 1s 95c guess what it would return? I'd return that you're buying 25 items for 1s 95c. Also adding: MainWindowViewModel.Dispatcher.BeginInvoke(new Action(() => { Items.Clear(); <----------- THIS solves lots of problems for me. Also when you're trying to maintain which items have Notify enabled with the little loop that is before "MainWindowViewModel.Dispatcher.BeginInvoke(new Action(() =>" I think you should use ListingID instead. I did a little modification so if Notify is enabled on Buying List, all the newly added items have Notify enabled by default. But if there was an item that was outbid earlier and I order new one of the same type, TPN would pass the deactivated Notify to the completely new bid forcing me to manually check Notify again. Ofc it wont work correctly since the SearchResult() function is bugged.

Zicore commented 11 years ago

Feel free to make a pull request :)