search

Zicrael / ngx-tree-dnd

Angular 7 support, data sortable draggable smart tree.
https://ngx-tree-dnd.stackblitz.io
MIT License
39 stars 11 forks source link

onAddItem doesn't work #18

Closed ahmadaf94 closed 5 years ago

ahmadaf94 commented 5 years ago

Describe the bug when onAddItem event triggers returns wrong parentList

To Reproduce Steps to reproduce the behavior:

  1. Go to https://stackblitz.com/edit/ngx-tree-dnd
  2. make a console.log(event) in line 71.
  3. Click on add new item button in front of Iphone item.
  4. See console that shows the google play as parent not the apple item.
Zicrael commented 5 years ago

@AhmadAfshari thank you for find this strange bug! I try fix this bug today.

kapilpundit commented 5 years ago

@Zicrael Hi, has this issue been fixed?

Zicrael commented 5 years ago

@kapilpundit Hey man, almost i think i fix it today. Need time for this.

kapilpundit commented 5 years ago

Ok, no problem. Take your time. But not too much.

Zicrael commented 5 years ago

@kapilpundit , @AhmadAfshari this issue was fixed in 2.4.2 version. Please update package. Thank you for report this issue!

Zicrael commented 5 years ago

https://stackblitz.com/edit/ngx-tree-dnd check again. All work fine. Thank you for report, i close the issue. In clsoe future i want improve this package to 3.0.0 version. With some new features.

kapilpundit commented 5 years ago

Thanks man, you saved the day. Really appreciate your effort.