search

Zicrael / ngx-tree-dnd

Angular 7 support, data sortable draggable smart tree.
https://ngx-tree-dnd.stackblitz.io
MIT License
39 stars 11 forks source link

Change detection minor fixes #29

Closed njofce closed 5 years ago

njofce commented 5 years ago

Fixes some bugs introduced by the previous PL. Removed method calls on timeout since they were not adding any timeout and broke some change detection functionality.

codecov[bot] commented 5 years ago

Codecov Report

Merging #29 into master will increase coverage by 0.03%. The diff coverage is 6.66%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #29      +/-   ##
==========================================
+ Coverage   30.92%   30.95%   +0.03%     
==========================================
  Files           9        9              
  Lines         443      449       +6     
  Branches       42       42              
==========================================
+ Hits          137      139       +2     
- Misses        306      310       +4
Impacted Files Coverage Δ
...jects/ngx-tree-dnd/src/lib/ngx-tree-dnd.service.ts 14.83% <0%> (-0.09%) :arrow_down:
...lib/directives/ngx-tree-dnd-autofocus.directive.ts 55.55% <0%> (+10.1%) :arrow_up:
...x-tree-dnd-parent/ngx-tree-dnd-parent.component.ts 29.67% <16.66%> (-0.57%) :arrow_down:
...ee-dnd-children/ngx-tree-dnd-children.component.ts 30.18% <33.33%> (+0.77%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 12a6c67...3c08146. Read the comment docs.