search

Zicrael / ngx-tree-dnd

Angular 7 support, data sortable draggable smart tree.
https://ngx-tree-dnd.stackblitz.io
MIT License
39 stars 11 forks source link

Add onClickItem event #54

Open GreenRover opened 4 years ago

GreenRover commented 4 years ago

I add the onClickItem event. This is an requirement of one of my project. where i have complex items in tree. And open onClick on the right halfe of the screen an bigger editing formular. There for is the href not very usefull.

You not need to add mentioned me as contributor.

codecov[bot] commented 4 years ago

Codecov Report

Merging #54 into master will decrease coverage by 0.34%. The diff coverage is 36.36%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #54      +/-   ##
==========================================
- Coverage   40.98%   40.63%   -0.35%     
==========================================
  Files           9        9              
  Lines         405      438      +33     
  Branches       37       40       +3     
==========================================
+ Hits          166      178      +12     
- Misses        235      256      +21     
  Partials        4        4
Impacted Files Coverage Δ
...x-tree-dnd-parent/ngx-tree-dnd-parent.component.ts 33.69% <33.33%> (-0.04%) :arrow_down:
...jects/ngx-tree-dnd/src/lib/ngx-tree-dnd.service.ts 35.6% <33.33%> (-0.24%) :arrow_down:
...ee-dnd-children/ngx-tree-dnd-children.component.ts 31.57% <50%> (+2.16%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b4f88b1...5747498. Read the comment docs.

GreenRover commented 4 years ago

@Zicrael Hi is this pull request acceptable for you?

andy008 commented 3 years ago

I've just included this code and it works nicely. Would be good to see it merged. Thank you @GreenRover :-)

CrackerakiUA commented 3 years ago

tested on npm i --save https://github.com/GreenRover/ngx-tree-dnd.git#dev-branch and on npm i --save https://github.com/GreenRover/ngx-tree-dnd.git. On both event is not fired

<lib-ngx-tree-component (onClickItem)="onClickItem($event)"></lib-ngx-tree-component>

@Zicrael this is really helpful feature, would be nice to have it under plugin. @GreenRover Could you also update readme?

GreenRover commented 3 years ago

@CrackerakiUA sorry dont like to invest in a dead project, please see how old this pr is