Zidras / DBM-Warmane

DBM for Warmane (Icecrown, Lordaeron, Frostmourne, Onyxia)
https://discord.gg/CyVWDWS
149 stars 67 forks source link

[BUG] #100

Closed Ithiloneth closed 2 years ago

Ithiloneth commented 2 years ago

Describe the bug Timers for Ragnaros in Molten Core break; I.E stop displaying.

Submerge/Emerge

Wrath of Ragnaros

Context It is entirely possible that this encounter should only include one Submerge, and that upon the second Submerge Ragnaros stays down until the raid is wiped or goes into some sort of enraged mode. Our MC is tweaked to challenge the players and so I bid you take any such possible change into account. The Wikis make no mention of any such limit on the phases though and indeed it is implied in various places that the fight can take very long to finish; having many phase transitions would then be a matter of course.

DBM Version 7.09 (7009)

To Reproduce Steps to reproduce the behavior:

  1. Start a fight with Ragnaros
  2. Pay close attention to timers during Submerge/Emerge transitions

Expected behavior The timer for Submerge/Emerge displays time left until the next transition. The timer for WoR starts at 25s each time Ragnaros Emerges, not matter what CD state it had when he Submerged.

Video https://www.twitch.tv/videos/1258326836?t=02h46m17s *Video shows the second submerge during an encounter. It also includes many more encounters and the timers fail in this manner during most (all?) of them.

Additional context Server: Chromie Craft, Azeroth Core, 3.3.5

Error Log

Ithiloneth commented 2 years ago

Sorry to be making more issue reports Zidras; I am recently become an active raider and since your DBM is the best one by far I'm now invested in ironing out any issues I find. Sadly I don't have the know-how to script for DBM and so can't make pull-requests. Might look into that in future if this becomes a regular thing.

Zidras commented 2 years ago

Reports are the way to go when it comes to bugfixing 👍

Having said that, from your report, two things invalidate it: different server than warmane, tweaked content. This means that there are different scripts being applied, and most likely different events (without transcriptor log, can't tell). Closing this unless it can be replicated on warmane.

Ithiloneth commented 2 years ago

I am sorry to hear you can't/won't look at the LUA. It is great that you provide the Transcriptor tool though as I will have to take this into my own unqualified hands. Now the question becomes: how do I get to Ragnaros and get to testing the addon?

I'll figure something out. Maybe.

Thanks!

Zidras commented 2 years ago

I am sorry to hear you can't/won't look at the LUA. It is great that you provide the Transcriptor tool though as I will have to take this into my own unqualified hands. Now the question becomes: how do I get to Ragnaros and get to testing the addon?

I'll figure something out. Maybe.

Thanks!

Don't get me wrong, I did look into the Lua file, but since there is no Lua error, there's not enough info to proceed with helping you troubleshoot the why's. Transcriptor is quite straightforward to use (there's an how to use on the github repo). Once you procure a log, I'll help you decipher it

Ithiloneth commented 2 years ago

Thank you Zidras - I will get you logs! On PTR now.

Ithiloneth commented 2 years ago

It took a while but I've got a good log now. If there are many TS in there it should be the most recent one!

Start: OK First Submerge: OK First Emerge: OK

Second Submerge: Breaks both as per above. Second Emerge: Remains broken, Wrath timer returns after it has been cast once.

Third Submerge: Breaks Wrath; Submerge/Emerge remains broken from before. Third Emerge: Remains broken, Wrath timer returns after it has been cast once.

I tried pasting the log; it was too long to be very usable. Not sure how to upload a file so here is a WeTransfer link: https://we.tl/t-vLYrdEB5nL

Zidras commented 2 years ago

Nothing screams at me, so you'll have to do a bit of debugging on your own, by adding print lines to see if they run. Something like this

function mod:CHAT_MSG_MONSTER_YELL(msg)
    print(msg, msg == L.Submerge)
    if msg == L.Submerge then
        print("DBM YELL: submerge sync")
        self:SendSync("Submerge")
    elseif msg == L.Pull and self:AntiSpam(5, 4) then
        self:SendSync("SummonRag")
    end
end

function mod:OnSync(msg, guid)
    if msg == "SummonRag" and self:AntiSpam(5, 2) then
        timerCombatStart:Start()
    elseif msg == "Submerge" and self:IsInCombat() then
        print("DBM: Submerge sync received")
Ithiloneth commented 2 years ago

I'll give that a go - thanks!