Closed ForestJ316 closed 2 years ago
Hello @ForestJ316, sorry for the delay in going through your PR. So regarding the dropdown edit, ~it will be worth pursuing a bit more testing on your end, since I can't repro the oob behaviour of the dropdown~ just reproduced this on a different language.
Without edit:
With your edit:
In fact, after applying the edit, since you're limiting the max width, the truncating of the dropdown happens sooner:
There is a bug with the dropdown in Thaddius options. If the string width was too high the button just went out of clickable bounds. Note that it was possible to fix this by adding \n to the string with high width in locale instead, but it made the dropdown look not so nice. If you think this will break something with menus then I will PR the \n fix instead. From what I checked everything seemed to stay same though.
Before:
After:
![Thaddius fix showcase](https://user-images.githubusercontent.com/91183260/159043476-785589ec-755c-4b43-ac2b-5ba4df336d53.png)
I also fixed the dropdown button overlapping in Gruul options.
Updated one looks like this
![gruul new dropdown fix](https://user-images.githubusercontent.com/91183260/159044141-3b3afe3c-9dce-4652-83ce-76e78294ae60.png)