search

Zidras / DBM-Warmane

DBM for Warmane (Icecrown, Lordaeron, Frostmourne, Onyxia)
https://discord.gg/CyVWDWS
147 stars 63 forks source link

Sartharion: fix Drake debuff check #126

Closed ForestJ316 closed 2 years ago

ForestJ316 commented 2 years ago

Looks like old code wanted to use Blizzard API to check for debuff but used DBM function instead, this resulted in nil being returned and timers not activating for Drake mechanics on OS 1D+. https://github.com/Zidras/DBM-Warmane/blob/88728ccd0e7b8d1a3724fe9acadb5234918d1134/DBM-Core/DBM-Core.lua#L5871-L5880

Zidras commented 2 years ago

Hey @ForestJ316 , just reviewed your PR, thanks for identifying the busted function. To go into a bit more detail, the problem is that it mixed two different arguments together into a frankenstein debuff checker that is just wrong. Basically it was iterating through group members and applying that i in the [wrong, should not have been DBM:] UnitDebuff function, which it applies that i in the aura index.

However I don't agree with your approach, because you assume the player will always have the debuffs, which would fail in case of premature death by the player. I'll push a correction to your branch and probably merge after. If you happen to catch this message, take a look and give me feedback

ForestJ316 commented 2 years ago

@Zidras Yeah, didn't consider player dying before the debuff check. Checking for debuff in general seems like the correct approach indeed.