search

Zidras / DBM-Warmane

DBM for Warmane (Icecrown, Lordaeron, Frostmourne, Onyxia)
https://discord.gg/CyVWDWS
152 stars 71 forks source link

Sartharion: cancel whelps timer after whelps spawn #135

Closed ForestJ316 closed 2 years ago

ForestJ316 commented 2 years ago

Canceling the timer on first whelp targeted. Right now the keep argument makes the timer last for the whole fight.

Zidras commented 2 years ago

The Whelps have no event associated to it? And the variance is 60-62s? if it's that small, I think we can revert the "keep" and maintain 60s.

Can also just accept the PR, the code is good. I leave it to you to decide what would feel better in raid context

Zidras commented 2 years ago

@ForestJ316 have you had the chance to look into this?

ForestJ316 commented 2 years ago

@Zidras I will try to do a transcriptor log the next time I am in OS, should be this id.

The variance indeed looks like 60-62s. But from what I'm seeing it might be 18s flat after he opens portal/starts hatching eggs. At least that's how it appears to be when it's 60s and when it's later, just he opened portal later. I'm not sure if there is any event other than locale specific msg for it though.

As for the keep arg I figured it should be fine to revert it since it shouldn't matter for this mechanic even if it's 2s later.

Zidras commented 2 years ago

I'll merge this to correct infinite keep timer. If needed, open a new one. Thanks