Zidras / DBM-Warmane

DBM for Warmane (Icecrown, Lordaeron, Frostmourne, Onyxia)
https://discord.gg/CyVWDWS
147 stars 63 forks source link

[REQUEST] Designation of the name in the BG table. #137

Closed moonxds closed 2 years ago

moonxds commented 2 years ago

Can you pleasse change it?

Before: https://imgur.com/a/rNt2L7W

Now: :( https://imgur.com/a/mdIW6dC

Thank you.

Zidras commented 2 years ago

How before are we talking about? what version Also test with only dbm

moonxds commented 2 years ago

I do not know what version exactly, because after downloading your version I have to replace the DBM-PvP folder, because it is as I wrote.

Zidras commented 2 years ago

attach here that dbm-pvp folder

moonxds commented 2 years ago

DBM-PvP.zip

Zidras commented 2 years ago
image

this works for you?

Zidras commented 2 years ago

your suggestion/blizzard is not suited for color. Not everyone has perfect eyesight and can perceive colors accurately:

image
moonxds commented 2 years ago

No, I mean my nickname is yellow. I can find it quickly in the table.

moonxds commented 2 years ago

Yes, i mean this

Zidras commented 2 years ago

your suggestion/blizzard is not suited for color. Not everyone has perfect eyesight and can perceive colors accurately: image

This I won't implement, for the reason I explained in the post.

I will however push the > name < , which makes more sense from a UI/UX perspective

moonxds commented 2 years ago

OK, i understand you. Thank you, he reacted so quickly to my suggestion.

moonxds commented 2 years ago

Could you please share the yellow color version of the nickname you made for me?

Zidras commented 2 years ago

This will be fixed by this commit https://github.com/Zidras/DBM-Warmane/commit/ffde9f38f4488d41a5ffed508155dc452fb604ba

To see color instead, do this

if name and name ~= playerName then
image
moonxds commented 2 years ago

OK, thank you so much.