search

Zidras / DBM-Warmane

DBM for Warmane (Icecrown, Lordaeron, Frostmourne, Onyxia)
https://discord.gg/CyVWDWS
150 stars 70 forks source link

Issue with /dbm unlock #19

Closed solarblazin closed 3 years ago

solarblazin commented 3 years ago

/dbm unlock is pretty broken, it creates the "unlock" bar, but it is not movable and it also throws a LUA error

this happens even with only DBM being enabled

Lua error: Message: Interface\AddOns\DBM-StatusBarTimers\DBT.lua:961: attempt to concatenate local 'text' (a nil value) Time: 07/26/21 02:42:53 Count: 1 Stack: Interface\AddOns\DBM-StatusBarTimers\DBT.lua:961: in function SetText' Interface\AddOns\DBM-StatusBarTimers\DBT.lua:1239: in functionShowMovableBar' Interface\AddOns\DBM-Core\DBM-Core.lua:1668: in function value' Interface\FrameXML\ChatFrame.lua:4070: in functionChatEdit_ParseText' Interface\FrameXML\ChatFrame.lua:3660: in function ChatEdit_SendText' Interface\FrameXML\ChatFrame.lua:3698: in functionChatEdit_OnEnterPressed'

solarblazin commented 3 years ago

Ah, just messed around with code

Lines 1239 and 1243 need to be edited with DBM_CORE_MOVABLE_BAR changed to DBM_CORE_L.MOVABLE_BAR in DBM-StatusBarTimers/DBT.lua file

Zidras commented 3 years ago

Looking at the code, I noticed infoframe is not being affected by this command. Will also look into it.

EDIT: Fixed: https://github.com/Zidras/DBM-Icecrown/commit/4cd9c8c8c8587e014988c6f94a8b9a8c9a7df187