search

Zidras / DBM-Warmane

DBM for Warmane (Icecrown, Lordaeron, Frostmourne, Onyxia)
https://discord.gg/CyVWDWS
146 stars 61 forks source link

Core: Fix pull detection by yell ignoring noMultiBoss #201

Open oomshroom opened 4 months ago

oomshroom commented 4 months ago

Fix logic error causing noMultiBoss set by DisableMultiBossPulls() to be ignored

Zidras commented 1 week ago

@oomshroom , your fix is indeed valid as it uncovers a faulty logic. However, this brings another problem to solve which is encounters that do have multiboss (OS 3 drakes comes to mind, even though it currently has code to purposefully disable multiboss). Might I ask which case(s) led you to uncover this bug?

oomshroom commented 5 days ago

@oomshroom , your fix is indeed valid as it uncovers a faulty logic. However, this brings another problem to solve which is encounters that do have multiboss (OS 3 drakes comes to mind, even though it currently has code to purposefully disable multiboss). Might I ask which case(s) led you to uncover this bug?

In OS 3-drake it was causing the mods for each drake to start up, in addition to the Sartharion mod, resulting in duplicate warnings for Void Blast.

However, full disclosure, this happened on a different server which I am adapting this DBM for. I do not know if this bug does or does not manifest itself in any way on Warmane, so it would be understandable for this issue to not be a priority for you.